[PATCH] Fix BAD_NET_RESP error in DsReplicaSync

[Andrew Bartlett]

On Sat, 2017-07-22 at 22:29 +1200, Andrew Bartlett via samba-technical
wrote:
> This error has been plaguing out tests for a while making our
> replication tests flap.
> 
> I got it locally and with a network trace, which made it clear the
> issue is a lack of mutual exclusion between outbound GetNCChanges and
> DsReplicaSync operations.
> 
> This patch fixes that.
> 
> Please review.  I have it under a few private autobuilds just to be
> sure.  (Or more likely, to collect every other flapping test...)

I got 6/6 passes overnight. 

The only question in my mind now is if we should try for a specific
regression test.

It shouldn't be impossible, I think you could do it with two loops of
DsReplicaSync for a full sync in two directions simultaneously.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba