[PATCH] Use the same process and krb5 ccache when invoking samba-tool in drs tests

Andrew Bartlett abartlet at samba.org
Fri Jul 21 21:00:12 UTC 2017

On Sat, 2017-07-22 at 08:19 +1200, Andrew Bartlett via samba-technical
> This patch removes a number of calls to fork() inside python, and
> instead of passing -Uusername%password on the internal command line, we
> pass around the name of the krb5 credentials cache we already have. 
> I've not been able to quantify the speed benefits - there seems to be
> more noise than signal in the timing here, hence my other patch
> reducing idle time, but when we had these tests under perf/FlameGraph
> the string2key routines really dominated the time what was spent on the
> CPU. 

Actually, if I use my tevent_immediate patch as the baseline, it saves
about 80 seconds per repl_move test on my laptop.

Aside from making the timing more reliable, it is however independent
of that patch.

> Earlier in the thread, Jeremy looked over the C parts, but if someone
> could look over the rest that would be great!
> Please review!
> Thanks,
> Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list