[PATCH] Factor out smbd_smb2_create_file from smbd_smb2_create_send

Ralph Böhme slow at samba.org
Fri Jul 21 14:41:53 UTC 2017


On Fri, Jul 21, 2017 at 12:51:46PM +0200, Ralph Böhme via samba-technical wrote:
> Hi metze,
> 
> On Tue, Jul 18, 2017 at 11:13:15PM +0200, Stefan Metzmacher wrote:
> > >> From the attic.
> > >>
> > >> Please review&push if ok. Just passed a private autobuild.
> > > 
> > > Nice cleanup Ralph, thanks !
> > > 
> > > Reviewed-by: Jeremy Allison <jra at samba.org>
> > 
> > Please don't push this yet.
> > 
> > I've discussed with Ralph that we want to split out
> > two functions, one before calling SMB_VFS_CREATE_FILE()
> > and one after it. Similar to ntlmssp_server_preauth(),
> > ntlmssp_server_check_password() and ntlmssp_server_postauth().
> 
> attached. Please review&push if ok.

ok, currently incorporating feedback from metze...

Cheerio!
-slow



More information about the samba-technical mailing list