[PATCHES] Generate shorter name for extra python files
metze at samba.org
Fri Jul 21 12:39:38 UTC 2017
as this will take a bit to discuss, I'll prepare new talloc, tevent
and ldb releases without this.
We need an ldb release for 4.7.0rc3 which is planed for next Tuesday.
Am 13.07.2017 um 22:43 schrieb Andrew Bartlett via samba-technical:
> On Tue, 2017-07-11 at 10:50 +0200, Lukas Slebodnik wrote:
>>> The ABI files, which we use in Samba to check when we add new symbols
>>> or change function arguments, need not to be dependent on python
>>> versions, as Samba developers have multiple python3 versions installed,
>>> but we only want one ABI file.
>>> However, the vscript and the generated library needs to be python
>>> version specific.
>>> The old code did this by removing the cpython... string from the ABI
>>> file and symbol names before writing the file. You need to (carefully,
>>> as it is now a shorter and less unique string) do the same.
>> Here you are.
> Is it safe to assert that we won't change the ABI with an IS_PYTHON3 or
> similar macro?
> If so, then these are OK (in that respect, I've not done a full
> review), but if it is likely that we will add python3 only helper
> functions to one or other of the py*-util libraries, then we need to
> keep the distinct ABI files for 2 and 3, but not for 3.5, 3.6 et al.
> Andrew Bartlett
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: OpenPGP digital signature
More information about the samba-technical