Volker.Lendecke at SerNet.DE
Thu Jul 20 08:42:59 UTC 2017
On Wed, Jul 19, 2017 at 09:45:57AM +0200, Ralph Böhme wrote:
> On Sat, Jul 15, 2017 at 08:06:29AM +0200, Volker Lendecke wrote:
> > On Fri, Jul 14, 2017 at 02:39:38PM +0200, Ralph Böhme via samba-technical wrote:
> > > > nah, I'll try to swallow the big pill. :)
> > >
> > > doesn't apply to master, can you check?
> > The attached patchset survived a private autobuild against master as
> > of Friday around noon, and rebases properly on current master.
> ok, took me a while to get through. Really really nice cleanup!
> Everything reviewed-by-me, accept the missing lock-order checks already
> mentioned over phone and a few commits that should be squashed to avoid
> EFUNCTIONDEFINEDBUTNOTUSED, see:
I'd propose a different approach: We should make the functions public
with a header file in one commit, remove their use in a second commit
and then remove the then-public functions in a third one. This ensures
full autobuildability in every commit and also maintains a clean patch
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical