[PATCH] Factor out smbd_smb2_create_file from smbd_smb2_create_send
jra at samba.org
Tue Jul 18 21:16:44 UTC 2017
On Tue, Jul 18, 2017 at 11:13:15PM +0200, Stefan Metzmacher wrote:
> Hi Jeremy,
> >> From the attic.
> >> Please review&push if ok. Just passed a private autobuild.
> > Nice cleanup Ralph, thanks !
> > Reviewed-by: Jeremy Allison <jra at samba.org>
> Please don't push this yet.
Too late :-).
I'll stop the autobuild.
> I've discussed with Ralph that we want to split out
> two functions, one before calling SMB_VFS_CREATE_FILE()
> and one after it. Similar to ntlmssp_server_preauth(),
> ntlmssp_server_check_password() and ntlmssp_server_postauth().
Can you do that on Samba-technical next time so I at least
know you've got concerns about the patch ?
Otherwise it just looked like a great cleanup.
More information about the samba-technical