[PATCH] Factor out smbd_smb2_create_file from smbd_smb2_create_send

Stefan Metzmacher metze at samba.org
Tue Jul 18 21:13:15 UTC 2017


Hi Jeremy,

>> From the attic.
>>
>> Please review&push if ok. Just passed a private autobuild.
> 
> Nice cleanup Ralph, thanks !
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>

Please don't push this yet.

I've discussed with Ralph that we want to split out
two functions, one before calling SMB_VFS_CREATE_FILE()
and one after it. Similar to ntlmssp_server_preauth(),
ntlmssp_server_check_password() and ntlmssp_server_postauth().

That way it will be easier to convert SMB_VFS_CREATE_FILE()
into SMB_VFS_CREATE_FILE_SEND/RECV() in future. See
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=0db7d6e6d1e7
and
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=348dd6e7f2ab

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170718/c1eac483/signature.sig>


More information about the samba-technical mailing list