[PATCH] Version 3 - Additional fix and test for bug #12899 - smbclient "setmode" no longer works to clear attribute bits due to dialect

Richard Sharpe realrichardsharpe at gmail.com
Mon Jul 17 23:10:40 UTC 2017

On Mon, Jul 17, 2017 at 12:32 PM, Jeremy Allison <jra at samba.org> wrote:
> OK, here's the version I think we need for
> master.
> #1 - revert the incorrect patch.
> #2 - Do the actual fix by changing the SMB2 client
>         code to provide the same ABI as the SMB1
>         cli_setatr().
> #3 - Test this code works. This code is excercised
>         over both SMB1 and SMB2 so ensures the server
>         provies the correct semantics for both SMB1
>         and SMB2.
> Fro 4.7.x and earlier we only need patches #2 and #3
> for the backport, as those branches never got the
> incorrect patch reverted by #1.
> Please review and push if happy. Sorry for the original
> issue (caused by not having a proper regression
> test initially).

I hate to be a pain in the ass, but since smbclients's setmode command
appears to accept a list of +mode and -mode commands, perhaps your
test should also test that the code work by having something like +XY
-ZA or whatever.

Otherwise: RB+

Richard Sharpe

More information about the samba-technical mailing list