[PATCH] Version 2 - Additional fix and test for bug #12899 - smbclient "setmode" no longer works to clear attribute bits due to dialect upgrade

Jeremy Allison jra at samba.org
Sat Jul 15 05:48:01 UTC 2017


On Fri, Jul 14, 2017 at 10:46:15PM -0700, Jeremy Allison wrote:
> 
> Thinking about this on the drive home, it means
> that we just change the SMB2 code to match SMB1.
> 
> This means:
> 
> cli_setatr(cli, fname, FILE_ATTRIBUTE_NORMAL, 0);
> 
> specifies "no change" for both SMB1 and SMB2, and
> 
> cli_setatr(cli, fname, FILE_ATTRIBUTE_NORMAL, 0);
>
> means "clear all attributes" for both SMB1 and SMB2.

I meant:

  cli_setatr(cli, fname, 0, 0);

for "clear all attributes" of course, that's what
the existing code uses.



More information about the samba-technical mailing list