[PATCH] cracknames: add python test & fix issues (bug #12842)

garming at catalyst.net.nz garming at catalyst.net.nz
Thu Jul 13 11:05:56 UTC 2017


Because of the way it's being tested (which is fine), the 3rd patch is 
actually required for backporting the 2nd patch in order to keep 
everything tested. This means that BUG: should probably be on the third 
patch also.

Reviewed-by: Garming Sam <garming at catalyst.net.nz>

Also, just a note, we now have a knownfail.d directory for temporary 
failures so as to avoid merge conflicts. Make a new file in the 
directory with the test failure, and delete the failure afterwards.



On 2017-07-11 09:16, Bob Campbell via samba-technical wrote:
> On 10/07/17 17:18, Andrew Bartlett via samba-technical wrote:
>> On Mon, 2017-07-10 at 13:31 +1200, Bob Campbell via samba-technical
>> wrote:
>>> Hi again,
>>> Turns out that I actually broke the existing cracknames test with 
>>> this;
>>> oops. Attached is a patch which passes. The change is using a 
>>> different
>>> error code when it can't find the expected format.
>>> Thanks,
>>> Bob
>> Thanks Bob.  Can you confirm you have tested both against Windows?
>> One nit, normally the BUG lines go with the signed-off-by etc, not
>> first in the commit message.  Other than that:
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>> Thanks!
>> Andrew Bartlett
> Hi Andrew,
> Both tests do pass against Windows (2012R2).
> Thanks,
> Bob

More information about the samba-technical mailing list