fixing smbtorture base.createx_sharemodes_file test

Jeremy Allison jra at samba.org
Wed Jul 12 17:10:12 UTC 2017


On Tue, Jul 11, 2017 at 10:11:33AM -0700, Herb Lewis via samba-technical wrote:
> On 07/11/2017 09:24 AM, Herb Lewis via samba-technical wrote:
> >This test and base.createx_sharemodes_dir do not really test
> >handling of sharemode
> >conflicts because we close the first file handle before we attempt
> >to open the file again.
> >The problem with the fix is that it now makes the
> >base.createx_sharemodes_file test
> >take a long time because of the 1 second delay before we return
> >SHARING_VIOLATION
> >on those cases that now conflict. We probably need to set the
> >smb.conf parameter
> >"defer sharing violations = no" when this test is run and then
> >make sure it is back to
> >normal for the base.defer_open test.
> >
> >Is there is a way to do this in the automatic testing?
> Just as an FYI, running this test against Samba 4.6.2 with the
> default smb.conf setting
> took about 43 minutes. With "defer sharing violations = no" it took
> about 1 minute.

Might be worth running it against a new share that has
that setting.



More information about the samba-technical mailing list