[PATCH] Enable TDB mutexes by default in dbwrap and ctdb
Volker.Lendecke at SerNet.DE
Tue Jul 11 05:20:29 UTC 2017
On Tue, Jul 11, 2017 at 03:40:13AM +1000, Amitay Isaacs via samba-technical wrote:
> I wondered about that. As far as I can see we don't really use the
> TDB_SEQNUM feature in CTDB.
ctdb itself probably doesn't, but dbwrap_ctdb users might depend on
the sequence number being bumped up if the database changes.
> Does anyone remember why was it added in the first place?
> If we don't need the TDB SEQNUM feature, then I can drop it from CTDB.
It was added in the past for the notify databases, which are gone by
now. But it's a part of the published TDB API, and it would be a
surprise to dbwrap users if it did not work for ctdb managed
databases. Doing a quick grep shows that brlock.tdb uses it. Whether
that is really strictly needed is something I need to investigate, but
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical