[PATCH] cracknames: add python test & fix issues (bug #12842)

Bob Campbell bobcampbell at catalyst.net.nz
Mon Jul 10 21:16:43 UTC 2017

On 10/07/17 17:18, Andrew Bartlett via samba-technical wrote:
> On Mon, 2017-07-10 at 13:31 +1200, Bob Campbell via samba-technical
> wrote:
>> Hi again,
>> Turns out that I actually broke the existing cracknames test with this;
>> oops. Attached is a patch which passes. The change is using a different
>> error code when it can't find the expected format.
>> Thanks,
>> Bob
> Thanks Bob.  Can you confirm you have tested both against Windows?
> One nit, normally the BUG lines go with the signed-off-by etc, not
> first in the commit message.  Other than that:
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> Thanks!
> Andrew Bartlett
Hi Andrew,

Both tests do pass against Windows (2012R2).


More information about the samba-technical mailing list