[PATCH] Enable TDB mutexes by default in dbwrap and ctdb
amitay at gmail.com
Mon Jul 10 18:05:45 UTC 2017
On Tue, Jul 11, 2017 at 3:40 AM, Amitay Isaacs <amitay at gmail.com> wrote:
> On Tue, Jul 11, 2017 at 2:51 AM, Ralph Böhme <slow at samba.org> wrote:
>> Hi Amitay,
>> On Tue, Jul 11, 2017 at 01:06:07AM +1000, Amitay Isaacs wrote:
>> > Reviewed-by: Amitay Isaacs <amitay at gmail.com>
>> > I missed modifying dbwrap code with the latest change regarding
>> > of tdb_flags.
>> > Here are 2 additional patches that are required.
>> > 1. Do not pass tdb_flags to db attach controls
>> > 2. Ask CTDB for tdb open flags
>> afaict 2 result in TDB_SEQNUM not being enabled anymore. Afair this gets
>> requested on open by the client (ie smbd/dbwrap) and is never enabled in
>> without a CTDB_CONTROL_ENABLE_SEQNUM control?
> I wondered about that. As far as I can see we don't really use the
> TDB_SEQNUM feature in CTDB.
> Does anyone remember why was it added in the first place?
> If we don't need the TDB SEQNUM feature, then I can drop it from CTDB.
Till we figure out if TDB_SEQNUM is required or not, here are the updated
patches that maintain the existing behaviour.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3987 bytes
Desc: not available
More information about the samba-technical