[PATCH] cracknames: add python test & fix issues (bug #12842)

Andrew Bartlett abartlet at samba.org
Mon Jul 10 05:18:58 UTC 2017

On Mon, 2017-07-10 at 13:31 +1200, Bob Campbell via samba-technical
> Hi again,
> Turns out that I actually broke the existing cracknames test with this;
> oops. Attached is a patch which passes. The change is using a different
> error code when it can't find the expected format.
> Thanks,
> Bob

Thanks Bob.  Can you confirm you have tested both against Windows?

One nit, normally the BUG lines go with the signed-off-by etc, not
first in the commit message.  Other than that:

Reviewed-by: Andrew Bartlett <abartlet at samba.org>


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list