[EXTERNAL] Re: Review request: changes in samba vxfs plugin

[Pooja Mahadik]

Hi,

This is a kind reminder for this review request. I have incorporated initial comment from Jeremy. Also looking for review from 2nd reviewer.

Thanks & Regards,
-pooja 

On 6/26/17, 11:38 PM, "Pooja Mahadik" <Pooja.Mahadik at veritas.com> wrote:

    Earlier mail to samba-technical lists email failed, sending code diff again.
    
    Thanks,
    -pooja
    
    
    
    On 6/26/17, 11:30 PM, "Pooja Mahadik" <Pooja.Mahadik at veritas.com> wrote:
    
    >Hi Jeremy,
    >
    >I incorporated previous comment, please find attached updated diff.
    >
    >Thanks & Regards,
    >-pooja
    >
    >
    >
    >On 6/23/17, 4:32 PM, "Pooja Mahadik" <Pooja.Mahadik at veritas.com> wrote:
    >
    >>Hi Jeremy,
    >>
    >>Ok, I’m incorporating below comment.
    >>
    >>Thanks,
    >>-pooja
    >>
    >>
    >>
    >>
    >>On 6/23/17, 5:55 AM, "Jeremy Allison" <jra at samba.org> wrote:
    >>
    >>>On Thu, Jun 22, 2017 at 06:13:40PM +0000, Pooja Mahadik wrote:
    >>>> Hi,
    >>>> 
    >>>> Please review attached patch for changes in samba-vxfs plugin.
    >>>> We have implemented ‘set_dos_attributes_fn’ & ‘fset_dos_attributes_fn’ VFS operations for vxfs plugin. New implementation of these operations calls the default set dos attribute function(SMB_VFS_NEXT_SET_DOS_ATTRIBUTES) to set the given attribute. In addition to this, we are trapping set/clear of ‘read-only’ attribute to take some additional actions upon set/clear of read-only attribute.
    >>>> 
    >>>> Please revert in case of any queries/issues.
    >>>
    >>>One quick comment - can you change all the DEBUG(10,(...));
    >>>statements to the modern form. See README.coding:
    >>>
    >>>DEBUG statements
    >>>----------------
    >>>
    >>>Use these following macros instead of DEBUG:
    >>>
    >>>DBG_ERR log level 0             error conditions
    >>>DBG_WARNING     log level 1             warning conditions
    >>>DBG_NOTICE      log level 3             normal, but significant, condition
    >>>DBG_INFO        log level 5             informational message
    >>>DBG_DEBUG       log level 10            debug-level message
    >>>
    >>>Example usage:
    >>>
    >>>DBG_ERR("Memory allocation failed\n");
    >>>DBG_DEBUG("Received %d bytes\n", count);
    >>>
    >>>The messages from these macros are automatically prefixed with the
    >>>function name.
    >>>
    >>>Thanks !
    >>>
    >>>Jeremy.