[PATCH] ldb: Fix index out of bound in ldb_msg_find_common_values

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Thu Jul 6 10:20:17 UTC 2017


On 06/07/17 21:48, Lukas Slebodnik wrote:
> 
> Have you tried to run unit test with valgrind / ore some address/memory
> sanitizer?

No. I think I have lost that habit because I am so used to writing python
tests that act as clients, where valgrind tells you nothing at all useful. 

> Otherwise looks good to me. But it would be good to fix also comment from
> different mail in this thread about remove_dupes.
> 
> Thank you very much for unit tests. They helped us to find bug :-)
> I really appreciate it.

You are welcome.

Douglas
 
> LS
> 




More information about the samba-technical mailing list