[PATCH] samba-tool: Easily edit a users object in AD V3 with test

Alexander Bokovoy ab at samba.org
Tue Jul 4 19:55:42 UTC 2017

On ti, 04 heinä 2017, Daniele Dario via samba-technical wrote:
> :-)
> I know this doesn't count as review but LGTM.
> Always wondered how I'd have felt saying it ;-)
There was still an issue with the path. I fixed it and also updated a
list of targets to run the tests against and pushed to autobuild.

A path issue was in mktemp run -- mktemp creates a file itself, so we
either have to specify a specific path where to create it or make sure
TMPDIR is set. I choose the former option.

Also, our local AD targets are 

["ad_dc:local", "ad_dc_ntvfs:local", "fl2000dc:local", "fl2003dc:local", "fl2008r2dc:local"]

so I changed the tests to be scheduled against them.

/ Alexander Bokovoy

More information about the samba-technical mailing list