[PATCH] samba-tool: Easily edit a users object in AD V2 with test

[Rowland Penny]

On Tue, 4 Jul 2017 12:39:00 +0300
Alexander Bokovoy <ab at samba.org> wrote:

> On ti, 04 heinä 2017, Rowland Penny via samba-technical wrote:
> > On Mon, 3 Jul 2017 18:07:49 +0300
> > Alexander Bokovoy <ab at samba.org> wrote:
> > 
> > > Looks like it works! Great!
> > 
> > OK, one step forward, three steps back ;-)
> > 
> > How do you create a new file ?
> > 
> > I have created the edit.sh file in my local git, but when I run:
> > 
> > git commit -s -a
> > 
> > I get:
> > 
> > On branch master
> > Your branch is ahead of 'origin/master' by 1 commit.
> >   (use "git push" to publish your local commits)
> > Untracked files:
> > 	python/samba/tests/samba_tool/edit.sh
> > 
> > nothing added to commit but untracked files present
> > 
> > I don't think I should run 'git push' as, from reading the manpage,
> > it looks like this will try to create 'edit.sh' in the Samba git.
> git add <file>
> https://www.atlassian.com/git/tutorials/saving-changes

I did wonder about that, but 'man git commit' said this:

       The command git commit -a first looks at your working tree, notices
       that you have modified hello.c and removed goodbye.c, and performs
       necessary git add and git rm for you.

Looks like the manpage lies, because I was using '-a' and it didn't
add the file ;-)

I followed the suggestion and it worked, so I have attached my new
patches for editing users and the test for this.

Rowland 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba-tool-Easily-edit-a-users-object-in-AD.patch
Type: text/x-patch
Size: 6439 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170704/9fcc45a1/samba-tool-Easily-edit-a-users-object-in-AD.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Add-test-for-samba-tool-user-edit.patch
Type: text/x-patch
Size: 2343 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170704/9fcc45a1/Add-test-for-samba-tool-user-edit.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Add-code-to-run-the-tests-for-samba-tool-user-edit.patch
Type: text/x-patch
Size: 1182 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170704/9fcc45a1/Add-code-to-run-the-tests-for-samba-tool-user-edit.bin>