[PATCH] copy-chunk fails if src and dst file are on different tcons

Ralph Böhme slow at samba.org
Mon Jul 3 12:32:26 UTC 2017


On Mon, Jul 03, 2017 at 02:25:05PM +0200, David Disseldorp wrote:
> On Mon, 3 Jul 2017 11:19:08 +0200, Ralph Böhme via samba-technical wrote:
> 
> > just pushed this to autobuild.
> 
> Thanks for your work on this, Ralph. I do have one concern though - I
> see one regression when running the fs_specific dup_extents_src_lock and
> dup_extents_dest_lock tests atop btrfs (which supports dup-extents):
> 
> failure: samba3.smb2.ioctl fs_specific.dup_extents_src_lock(nt4_dc) [
> Exception: Exception: ../source4/torture/smb2/ioctl.c:6506: status was NT_STATUS_INTERNAL_ERROR, expected NT_STATUS_OK: FSCTL_DUP_EXTENTS_TO_FILE unlocked
> ...
> failure: samba3.smb2.ioctl fs_specific.dup_extents_dest_lock(nt4_dc) [
> Exception: Exception: ../source4/torture/smb2/ioctl.c:6612: status was NT_STATUS_INTERNAL_ERROR, expected NT_STATUS_OK: FSCTL_DUP_EXTENTS_TO_FILE unlocked
> 
> I'd prefer if this was fixed before the patchset goes in. I've only
> skimmed through the rest of the changes, but they look good on first
> impression.

lemme check. I did some manual tests with btfs, but I didn't run all tests. I
cancelled the autobuild.

Cheerio!
-slow



More information about the samba-technical mailing list