Releases, locking and ldb

[Stefan Metzmacher]

Am 02.07.2017 um 00:18 schrieb Stefan Metzmacher:
> Am 30.06.2017 um 23:47 schrieb Andrew Bartlett:
>> On Fri, 2017-06-30 at 23:00 +0200, Stefan Metzmacher wrote:
>>> Am 30.06.2017 um 22:23 schrieb Andrew Bartlett via samba-technical:
>>>> On Fri, 2017-06-30 at 23:03 +1200, Andrew Bartlett via samba-technical
>>>> wrote:
>>>>>
>>>>> Perhaps I'm tempting fate too much making changes after we got it all
>>>>> working, but I've attached my current thoughts.  I wish I could do more
>>>>> to actually remove the nested transactions, but now is not the time.
>>>>
>>>> Indeed, fate tempted.  Even this smaller 'safe' set fails autobuild,
>>>> which honestly scares me a little.  However we can't go down this rat-
>>>> hole today. 
>>>
>>> I've added the tdb_transaction_active(), but I'm not sure
>>> it will be the way to fix things in ldb. There's more discussion
>>> required. If we get something useful in the next weeks it can
>>> be backported as bugfix, it's not required to fix all bugs before
>>> 4.7.0rc1.
>>>
>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-ldb-1
>>> passed 'autobuild-private.sh samba samba-systemkrb5' twice. I'll some
>>> complete autobuilds now.
>>
>> I've fired off 5 more of that branch in the Catalyst Cloud.
>>
>>> I'll fix up the commit message and comments around the tests.
>>
>> Thanks!
>>
>>> The important thing that's not tested yet is that the
>>> ldb:wscript: define EXPECTED_SYSTEM_LDB_VERSION_{MAJOR,MINOR,RELEASE}
>>> commit release works to reject builds with older samba versions.
>>
>> Understood.  I'm going to try hard to spend the weekend with the
>> family, but perhaps Jeremy gets a chance before my Monday.
> 
> Ok, with the "ldb:wscript: define
> EXPECTED_SYSTEM_LDB_VERSION_{MAJOR,MINOR,RELEASE}" commit reverted,
> the autobuild target "samba-libs" triggers this:
> 
> In file included from ../source4/dsdb/common/util.c:27:0:
> /m/metze/W/b863444/prefix/samba-libs/include/ldb_module.h:68:2: error:
> #error "Samba < 4.7 is not compatible with this version of ldb due to
> assumptions around read locks"
>  #error "Samba < 4.7 is not compatible with this version of ldb due to
> assumptions around read locks"
>   ^
> Waf: Leaving directory `/memdisk/metze/W/b863444/samba-libs/bin'
> Build failed:  -> task failed (err #1):
>         {task: cc util.c -> util_6.o}
> 
> So it seems to work.
> 
> I'll finish up this stuff based on your ldb-safe-locking-13 branch.

I'll assume your reviewed-by, ok?

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170702/525f6fd1/signature.sig>