generated spotlight files (via bison/flex) from waf rather than use snapshots of previous generated files
Andrew Bartlett
abartlet at samba.org
Sat Jan 28 01:43:57 UTC 2017
On Fri, 2017-01-27 at 20:52 +0000, Noel Power wrote:
> Hi Ralf
> On 27/01/17 18:03, Ralph Böhme wrote:
> > On Fri, Jan 27, 2017 at 05:45:26PM +0000, Noel Power wrote:
> > > On 27/01/17 14:09, Ralph Böhme wrote:
> > > [...]
> > > > after discussing this with metze on the phone, metze is ok with
> > > > the change, but
> > > > suggests that we slightly enhance the configure check for flex
> > > > and bison to
> > > > display versions detected.
> > > >
> > > > Noel, do you have time to add this? If not, I'll see if I can
> > > > do it next
> > > > week.
> > >
> > > I should have time first thing on Monday (or maybe even sooner :-
> > > )),
> >
> > :)
> >
>
> how about the attached ?
Looks reasonable to me, assuming you sorted the SMB_MALLOC thing? I
can't see how that got handled compared to the earliest patch, but the
.l and .y files already seem to have the #defines.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list