libsmb2, meet samba
Steve French
smfrench at gmail.com
Fri Jan 27 18:12:20 UTC 2017
On Fri, Jan 27, 2017 at 12:11 PM, Steve French <smfrench at gmail.com> wrote:
> I would also strongly recommend hosting it on samba.org, and there is
> some value if (at least) some of the headers can be shared. Although
> cifs code had been ported to user space for testing (for spec e.g.), I
> like this better.
>
> My only nit (and it is a small one), is noting that at this stage
> there is near zero value (and some disadvantage in additional testing
> and coding) in enabling SMB2 dialect, it is easy enough to focus 100%
> on SMB3 and later dialects (or SMB2.1 or later). Leaving off the
> optional features of SMB3 until they are ready is fine, but there is
> almost zero value in ever negotiating SMB2 at this stage - but there
> would be HUGE value in having a good user space SMB3.0 or SMB3.11
> library that could be more broadly used by open source components that
> won't link to Samba today.
This e.g. in your libsmb2.c
memset(&req, 0, sizeof(struct smb2_negotiate_request));
req.struct_size = SMB2_NEGOTIATE_REQUEST_SIZE;
req.dialect_count = SMB2_NUM_DIALECTS;
req.security_mode = smb2->security_mode;
req.dialects[0] = SMB2_VERSION_0202;
req.dialects[1] = SMB2_VERSION_0210;
> On Wed, Jan 25, 2017 at 3:50 PM, ronnie sahlberg
> <ronniesahlberg at gmail.com> wrote:
>> On Wed, Jan 25, 2017 at 1:41 PM, Jeremy Allison <jra at samba.org> wrote:
>>> On Tue, Jan 24, 2017 at 07:31:33PM -0800, ronnie sahlberg wrote:
>>>> samba, please meet libsmb2
>>>> libsmb2 please meet samba
>>>>
>>>> Where to host?
>>>> --------------------
>>>> I kind of like github/sahlberg as your on-stop-shop for everything
>>>> related to network storage client software.
>>>> However, hosting this on samba.org at some stage might be a better choice.
--
Thanks,
Steve
More information about the samba-technical
mailing list