generated spotlight files (via bison/flex) from waf rather than use snapshots of previous generated files

Ralph Böhme slow at samba.org
Fri Jan 27 14:09:17 UTC 2017


Hi!

On Fri, Jan 20, 2017 at 04:27:57PM +0100, David Disseldorp wrote:
> On Fri, 20 Jan 2017 15:37:45 +0100, Ralph Böhme wrote:
> 
> > I've not submitted my fixed for bug ... in a seperate thread. I think it's
> > easier to seperate both issues (I know it was me who jumped the train... ;) ).
> > 
> > Attached is an updated version of you path that goes on top of the other patches
> > with one change in source3/wscript:
> > 
> > when checking for flex/bison we must log a message "Spotlight support requested,
> > checking for...", because the flex/bison checks in waf will only fail with
> > "flex/bison not found" without further indication from configure that this is
> > related to requesting --enable-spotlight.
> 
> Looks good, and builds fine with bison-2.7-9.43 and flex-2.5.37-12.1
> (openSUSE 42.2):
> Reviewed-by: David Disseldorp <ddiss at samba.org>
> 
> I'll hold off pushing until Metze makes it clear whether or not he still
> objects to the change.

after discussing this with metze on the phone, metze is ok with the change, but
suggests that we slightly enhance the configure check for flex and bison to
display versions detected.

Noel, do you have time to add this? If not, I'll see if I can do it next week.

Cheerio!
-slow



More information about the samba-technical mailing list