[PATCH] Fix dn+binary linked attribute behavior (bug 11139)

Andrew Bartlett abartlet at samba.org
Fri Jan 27 06:24:57 UTC 2017


On Thu, 2017-01-26 at 16:25 +1300, Bob Campbell wrote:
> Hi,
> 
> The test would fail if run twice in a row, and so didn't make it past
> autobuild. This was due to there being colliding linkIDs, which
> messes
> up the deletion of backlinks. 

Nice find!

> Here's a new patchset which includes a
> patch to disallow attributes with duplicate linkIDs to be added,
> unless
> DSDB_CONTROL_SKIP_DUPLICATES_CHECK_OID is set. The test has also been
> changed slightly to find a non-duplicate linkID.

I rather expected the check to be like the OID checks in the samldb
module.  I'm concerned that the loaded schema may also not be current,
and so I think we should instead search the DB for the duplicate linkID
(or perhaps the loaded schema is always current enough these days). 

Thanks,

Andrew Bartlett

> Please review and push if appropriate.
> 
> Thanks,
> Bob
> 
> 
> On 06/01/17 11:19, Douglas Bagnall wrote:
> > hi Bob,
> > 
> > On 06/01/17 09:44, Bob Campbell wrote:
> > > Hi Douglas,
> > > 
> > > Thanks for having a look at this.
> > > Attached are patches with these issues fixed.
> > 
> > Good! RB+.
> > 
> > Douglas
> > 
> > 
> > > Thanks,
> > > Bob
> > > 
> > > On 05/01/17 17:05, Douglas Bagnall wrote:
> > > > hi Bob,
> > > > 
> > > > I see a couple of superficial issues.
> > > > >  
> > > > > +import os
> > > > 
> > > > You don't actually use this.
> > > > 
> > > > > @@ -37,12 +40,11 @@ from ldb import (
> > > > >      Message,
> > > > >      FLAG_MOD_ADD,
> > > > >      FLAG_MOD_REPLACE,
> > > > > +    FLAG_MOD_DELETE
> > > > >      )
> > > > 
> > > > or this.
> > > > 
> > > > > +
> > > > > +        link_end_dn = ldb.Dn(self.ldb_dc1, "OU=test_ou,%s" %
> > > > > str(self.ldb_dc1.get_default_basedn()))
> > > > 
> > > > here the line length is getting a bit out of control and the
> > > > str() is
> > > > redundant (because "%s" implies str()). There are other
> > > > instances of that.
> > > > 
> > > > > +
> > > > > +        self._net_drs_replicate(DC=self.dnsname_dc2,
> > > > > fromDC=self.dnsname_dc1, nc_dn=self.schema_dn, forced=True)
> > > > > +        self._net_drs_replicate(DC=self.dnsname_dc2,
> > > > > fromDC=self.dnsname_dc1, nc_dn=self.domain_dn, forced=True)
> > > > > +
> > > > 
> > > > and line length again.
> > > > 
> > > > > From 0a1a65c99e6b8ec39ad0c7018e05759343899e51 Mon Sep 17
> > > > > 00:00:00 2001
> > > > > From: Andrew Bartlett <abartlet at samba.org>
> > > > > Date: Mon, 12 Oct 2015 15:51:37 +1300
> > > > > Subject: [PATCH 2/2] repl_meta_data: Remove the correct
> > > > > linked attribute
> > > > >  forward link
> > > > 
> > > > This one looks good.
> > > > 
> > > > cheers,
> > > > Douglas
> > > > 
> 
> 
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list