[PATCH] Python3 compatible modules - credentials, param, _glue

[Andrew Bartlett]

On Sat, 2017-01-14 at 07:05 +1300, Andrew Bartlett wrote:
> On Fri, 2017-01-13 at 12:01 +0100, Lumir Balhar wrote:
> > > On 01/05/2017 07:10 PM, Andrew Bartlett wrote: 
> > > > On Thu, 2017-01-05 at 14:01 +0100, Lumir Balhar wrote: 
> > > > > On 12/22/2016 07:00 PM, Andrew Bartlett wrote: 
> > 
> >  [...] 
> > > > > Perhaps skip the raw DCE/RPC tests, add some expected value
> > > > > testing 
> > > > > to 
> > > > > samba/tests/auth.py and run samba/tests/gensec.py? 
> > > > 
> > > >  Ok, I can skip tests of DCE/RPC and run tests of gensec but
> > > > first I 
> > > > need 
> > > > to port samba.gensec module and samba.tests.gensec. It looks
> > > > like 
> > > > that 
> > > > it will be simple without another dependency chain. 
> > > 
> > >  Good! 
> > 
> >  
> > It seems that my expectations were wrong. I found out that tests of
> > the 
> > gensec module are planned old way with planoldpythontestsuite()
> > function 
> > which is not prepared for Python 3 yet. 
> > Of course, I can port this functionality as well but I've
> > discovered 
> > another long dependency chain which goes through modules getopt, 
> > hostconfig, dsdb, dsdb_dns and maybe more - so it will take some
> > time
> > to 
> > do it and it will add other changes to patchset. 
> > 
> > This is just a heads-up that the patchset will be even larger than
> > expected, unless you see a different way forward. 
> 
> I do.  
> 
> You should be able to prove to yourself that HostConfig is unused,
> except for tests, but the easiest course of action is to remove
> get_hostconfig() from the getopt.py script, as that is both unused
> and
> untested.
> 
> The HostConfig abstraction never really took off, despite looking
> like
> a reasonable idea, so you can also remove the get_samdb() call from
> it
> as well if that is helpful somehow.
> 
> That should cut down the dep chain for now.  When we get back to it,
> it
> looks like there is some other code here we should remove or finally
> use. 

Do you have an updated patch set?  I'm hoping we can land this without
a disastrous conflict with the --disable-python patch set, and it would
be helpful to see the current state of play.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba