[PATCH 29] Re: Disabling Python Modules

[Andrew Bartlett]

On Wed, 2017-01-25 at 13:19 +0100, Petr Viktorin wrote:
> On 01/25/2017 09:29 AM, Stefan Metzmacher wrote:
> > Hi Ian,
> > 
> > > I can't be certain, but I think that may indeed be the last of
> > > them.
> > > All wscript_build files that contain modules with deps= including
> > > py*util, and LIBPYTHON, are now all covered.
> > 
> > I know I'm late in the discussion, but is there a chance
> > that we could avoid all changes like this:
> > 
> > -bld.SAMBA3_PYTHON('pys3param',
> > +if not bld.env.disable_python:
> > +    bld.SAMBA3_PYTHON('pys3param',
> > 
> > And just to that globally within SAMBA_PYTHON()
> > instead of changing each caller?
> > The same applies to CHECK_BUNDLED_SYSTEM_PYTHON()
> > and SAMBA_CHECK_PYTHON_HEADERS()
> 
> That would also conflicts with the Python3 enablement patches, where
> all 
> these calls eventually need to be wrapped for-loop to possibly build 
> with both Python versions.

I would strongly request that any patches we have to disable python
make Petr's work easier, not harder.  I've been putting off merging
Petr's very good patches while I wait for a little more to be
completed, but it would be really unfortunate if he had to re-do a bit
chunk of his work because this landed first.

Please re-base the patches on Petr's patches, or show that they
trivially rebase on yours (say by working inside the SAMBA_PYTHON
layer). 

I know this is frustrating, but we need to land this both these ideas
successfully.  

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba