[PATCH 29] Re: Disabling Python Modules

[Ian Stakenvicius]

On 24/01/17 08:37 PM, Ian Stakenvicius wrote:
> On 24/01/17 07:50 PM, Ian Stakenvicius wrote:
>>
>>> On Jan 24, 2017, at 7:38 PM, Jeremy Allison <jra at samba.org> wrote:
>>>
>>>> On Mon, Jan 23, 2017 at 11:51:33AM -0500, Ian Stakenvicius wrote:
>>>>> On 23/01/17 11:13 AM, Ian Stakenvicius wrote:
>>>>>> On 20/01/17 01:45 PM, Ian Stakenvicius wrote:
>>>>>>> On 18/01/17 08:03 PM, Jeremy Allison wrote:
>>>>>>>> On Wed, Jan 18, 2017 at 03:05:58PM -0500, Ian Stakenvicius wrote:
>>>>>>>> [...]
>>>>>>>> I'll work on separating things out into appropriate segments, and
>>>>>>>> getting the patches into git locally so they can be committed as-is
>>>>>>>> later on.
>>>>>>>
>>>>>>> Hi Ian, that's fantasic news ! Thanks for helping us with that !
>>>>>>>
>>>>>>> Can you send us in an email as described here:
>>>>>>>
>>>>>>> https://www.samba.org/samba/devel/copyright-policy.html
>>>>>>> [..]
>>>>>>
>>>>>> Done.
>>>>>>
>>>>>> OK, the patchset is prepared for email; there's 27 (edit: 28) commits in it, and
>>>>>> I've provided the titles below.  Should some of these be squashed
>>>>>> together before I send them or should they remain separate?
>>>>>
>>>>> Received advice from #samba-technical.  Please find attached the
>>>>> patchset as previously linked and described.
>>>>>
>>>>> Regards,
>>>>> Ian
>>>>
>>>> New version attached for review, with proper signoffs in place.
>>>
>>> Thanks a *LOT* for this Ian !
>>>
>>> However, in master, when I apply this patchset and configure
>>> using:
>>>
>>> buildtools/bin/waf configure --enable-pthreadpool --with-acl-support --enable-developer --picky-developer --disable-python
>>>
>>> and then do:
>>>
>>> make -j
>>>
>>> I get:
>>>
>>> WAF_MAKE=1 python ./buildtools/bin/waf build
>>> Waf: Entering directory `/space/jra/src/samba/git/merge-1/bin'
>>>    Selected embedded Heimdal build
>>> symlink: samba-tool -> ./samba-tool
>>> symlink: samba_dnsupdate -> ./samba_dnsupdate
>>> symlink: samba_spnupdate -> ./samba_spnupdate
>>> symlink: samba_kcc -> ./samba_kcc
>>> symlink: samba_upgradeprovision -> ./samba_upgradeprovision
>>> symlink: samba_upgradedns -> ./samba_upgradedns
>>> symlink: smbaddshare -> ./smbaddshare
>>> symlink: smbchangeshare -> ./smbchangeshare
>>> symlink: smbdeleteshare -> ./smbdeleteshare
>>> Checking project rules ...
>>> Unknown dependency 'LIBPYTHON' in 'service_web.objlist'
>>> make: *** [all] Error 1
>>>
>>> So I think there's another patch needed for:
>>>
>>> source4/web_server/wscript_build
>>>
>>> but my python isn't good enough to create it yet,
>>> sorry.
>>>
>>> Jeremy.
>>>
>>
>> That part I can do; 
> 
> ..and, done.  See attached.
> 


I can't be certain, but I think that may indeed be the last of them.
All wscript_build files that contain modules with deps= including
py*util, and LIBPYTHON, are now all covered.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170124/bc7a618d/signature.sig>