[PATCH try2] Re: Disabling Python Modules

Jeremy Allison jra at samba.org
Wed Jan 25 00:38:55 UTC 2017


On Mon, Jan 23, 2017 at 11:51:33AM -0500, Ian Stakenvicius wrote:
> On 23/01/17 11:13 AM, Ian Stakenvicius wrote:
> > On 20/01/17 01:45 PM, Ian Stakenvicius wrote:
> >> On 18/01/17 08:03 PM, Jeremy Allison wrote:
> >>> On Wed, Jan 18, 2017 at 03:05:58PM -0500, Ian Stakenvicius wrote:
> >>>> [...]
> >>>> I'll work on separating things out into appropriate segments, and
> >>>> getting the patches into git locally so they can be committed as-is
> >>>> later on.
> >>>
> >>> Hi Ian, that's fantasic news ! Thanks for helping us with that !
> >>>
> >>> Can you send us in an email as described here:
> >>>
> >>> https://www.samba.org/samba/devel/copyright-policy.html
> >>> [..]
> >>
> >> Done.
> >>
> >> OK, the patchset is prepared for email; there's 27 (edit: 28) commits in it, and
> >> I've provided the titles below.  Should some of these be squashed
> >> together before I send them or should they remain separate?
> > 
> > Received advice from #samba-technical.  Please find attached the
> > patchset as previously linked and described.
> > 
> > Regards,
> > Ian
> > 
> 
> New version attached for review, with proper signoffs in place.

Thanks a *LOT* for this Ian !

However, in master, when I apply this patchset and configure
using:

buildtools/bin/waf configure --enable-pthreadpool --with-acl-support --enable-developer --picky-developer --disable-python

and then do:

make -j

I get:

WAF_MAKE=1 python ./buildtools/bin/waf build
Waf: Entering directory `/space/jra/src/samba/git/merge-1/bin'
	Selected embedded Heimdal build
symlink: samba-tool -> ./samba-tool
symlink: samba_dnsupdate -> ./samba_dnsupdate
symlink: samba_spnupdate -> ./samba_spnupdate
symlink: samba_kcc -> ./samba_kcc
symlink: samba_upgradeprovision -> ./samba_upgradeprovision
symlink: samba_upgradedns -> ./samba_upgradedns
symlink: smbaddshare -> ./smbaddshare
symlink: smbchangeshare -> ./smbchangeshare
symlink: smbdeleteshare -> ./smbdeleteshare
Checking project rules ...
Unknown dependency 'LIBPYTHON' in 'service_web.objlist'
make: *** [all] Error 1

So I think there's another patch needed for:

source4/web_server/wscript_build

but my python isn't good enough to create it yet,
sorry.

Jeremy.



More information about the samba-technical mailing list