[PATCH] Patch for bug 12520

Jeremy Allison jra at samba.org
Tue Jan 24 18:57:50 UTC 2017


On Tue, Jan 24, 2017 at 03:28:26PM +0100, Ralph Böhme wrote:
> On Thu, Jan 19, 2017 at 08:28:46AM +0100, Ralph Böhme wrote:
> > On Wed, Jan 18, 2017 at 06:41:45AM +1100, Andrew Bartlett wrote:
> > > On Mon, 2017-01-16 at 15:54 +0100, Ralph Böhme wrote:
> > > > Hi!
> > > > 
> > > > Attached is a fix for:
> > > > <https://bugzilla.samba.org/show_bug.cgi?id=12520>
> > > > 
> > > > I didn't add a test because that would require an additional server
> > > > in selftest
> > > > just for that. Shall I?
> > > 
> > > Given the issue we had around smb signing not being enabled for years
> > > in the AD DC because we didn't actually test it correctly in the
> > > default, let along all the reasonable configurations, I would really
> > > prefer the costs of the extra environments.  Particularly for the
> > > standalone fileserver, they are not expensive.
> > 
> > instead of adding a new env I got away with disabling it in the simpleserver
> > env. :)
> > 
> > The test then pointed me at our SMB1 UNIX extensions encrpytion code that got
> > this wrog as well.
> > 
> > Updated patchset attached. Please review & push if ok. Thanks!
> 
> is this one on anyones list? Thanks!

It is now :-). I'll review today.



More information about the samba-technical mailing list