generated spotlight files (via bison/flex) from waf rather than use snapshots of previous generated files

[Noel Power]

On 19/01/17 07:23, Ralph Böhme wrote:
> On Wed, Jan 18, 2017 at 07:51:58PM +0100, Ralph Böhme wrote:
>> Hi Noel,
>>
>> On Wed, Jan 18, 2017 at 02:11:19PM +0000, Noel Power wrote:
>>> I was trying to see in my WSP stuff how to get rid of a similar
>>> situation (I also use flex/bison) so this worked for me,. Attached is a
>>> patch for spotlight using the same technique I used, probably with more
>>> waf knowledge it could be improved (e.g. I would liked to have figured
>>> out some way to pass some info to third_party/waf/wafadmin/Tools/flex.py
>>> so that the 'rule' there could be changed to add the 'sed' stuff
>>> dynamically) but this should do for the moment, hopefully of this is of
>>> some use
>> I was made aware of an issue building Samba with --nonshared-binary=smbd/smbd
>> which fails when build with --enable-spotlight in two places.
>>
>> I've posted a patch for one place yesterday [1], the other place is:
>>
>> <https://bugzilla.samba.org/show_bug.cgi?id=12528>
>>
>> So as we have to fix the mdssvc lexer and parser files anyway, I'd like to base
>> the fix on your patch to integrate the generation into waf.
>>
>> Combined patch attached.
>>
>> I've slightly modified your patch and renamed the subsystem to "MDS_LEXER". What
>> do you think?
> another update: I always found it ugly running sed on the generated lexer to
> replace malloc and realloc with SMB_MALLOC and SMB_REALLOC respectively.
oh, that should make things easier
>
> After doing some research in the flex manual I found out the proper way to
> redefine the symbols.
ok this sounds better, will have a look this morning
>
> Cheerio!
> -slow

Noel