[PATCH] ctdb-scripts: Fix regression when cleaning up routing table IDs (bug 12516)
Amitay Isaacs
amitay at gmail.com
Tue Jan 17 01:19:46 UTC 2017
On Tue, Jan 17, 2017 at 12:01 PM, Martin Schwenke <martin at meltin.net> wrote:
> Commit 0ca00267cd2620a14968961738bcd2a69b597e95 removed explicit
> continuations in strings for awk programs. In one case this causes a
> disconnect between condition and action, where an implicit
> continuation does not work. This results in duplicate lines in the
> rt_tables file.
>
> Move the opening brace for the action to make the implicit
> continuation work as expected.
>
> An alternative would be to revert the removal of the explicit
> continuations and add shellcheck tags. However, that doesn't mean
> that an author of future code will necessarily use explicit
> continuations, so the same mistake might still be make in the future.
>
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12516
>
> Plus an extra commit containing a test...
>
> Please review and maybe push...
>
> peace & happiness,
> martin
>
Pushed to autobuild.
Amitay.
More information about the samba-technical
mailing list