[PATCH] Fix bug #10430

[Andreas Schneider]

On Monday, 16 January 2017 17:35:33 CET Mikhail Skorzhinskiy wrote:
> I've already tried to solve this bug[1] and submitted one patch[2]. Back
> then, I've done nothing to ensure it will compile under master and have
> not checked is it working or not. It was working in my environment and
> was enough for me.
> 
> Now I've finally have moved to samba 4.5.1. Basic tests says that WORM
> functionality works: writing from different initiator types are failing
> under WORM protection.
> 
> Attached patch is made from current master (and it's compiling). So,
> should I test it under current master? Or test that I've made under
> 4.5.1 is enough?

Thank you very much for your contribution.


Please test on master. Also looking at the commit message you are doing 
several things at once. The patch should be split up in at least 4 different 
commits.

Smaller commits are easier to review!


> I'm also slightly confused, is there are anybody using this WORM
> functionality (except me)? I would say bug is kind of blocking.


Marc used it, I'm not sure he still does. However it sounds like we need a 
test for this.


Best regards,


	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org