[PATCH] Drop configuration variable CTDB_SERVICE_AUTOSTARTSTOP

[Martin Schwenke]

On Mon, 16 Jan 2017 21:00:46 +1100, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Mon, Jan 16, 2017 at 8:10 PM, Martin Schwenke <martin at meltin.net> wrote:
> 
> > This drops a bit-rotted feature.  As mentioned in a commit message,
> > the feature could be fixed but it is really just unnecessary complexity
> > that probably isn't used by anyone.  If anyone is using it then they
> > can work around the disappearance of the feature quite trivially.
> >
> > The main commits are:
> >
> >   ctdb-scripts: Drop configuration variable CTDB_SERVICE_AUTOSTARTSTOP
> >   ctdb-scripts: Remove ctdb_service_start() and ctdb_service_stop()
> >
> > The rest are just clean-ups that follow on naturally from those 2.  The
> > net result is the removal of about 200 lines of code and 50 lines of
> > associated tests.  Less is more!  :-)
> >
> > Please review and maybe push...
> >
> >  
> Reviewed-by: Amitay Isaacs <amitay at gmail.com>
> 
> A minor fixup to second patch attached.  You can squash it in.

OK, done.  Thanks.

> Also noticed that shellcheck test for init_script uses the wrong variable.
> Patch attached.

Cool.  I changed the prefix in the commit message to ctdb-tests instead
of ctdb-scripts, since it only touches test code.

Reviewed-by: Martin Schwenke <martin at meltin.net>

> Is there any way to set CTDB_SCRIPTS_INIT_SCRIPT to
> $src/config/ctdb.init, so it can work within the source tree?

That's already done in the first arm of the "if" in
script_install_paths.sh.  So:

  $ ./ctdb/tests/run_tests.sh ./ctdb/tests/shellcheck/init_script.sh 

works already!

Pushed...

peace & happiness,
martin