[PATCH] Fix new Coverity IDs

Andreas Schneider asn at samba.org
Mon Jan 16 10:09:55 UTC 2017


On Friday, 13 January 2017 08:58:58 CET Andreas Schneider wrote:
> On Thursday, 12 January 2017 09:07:33 CET Jeremy Allison wrote:
> > On Thu, Jan 12, 2017 at 11:33:30AM +0100, Andreas Schneider wrote:
> > > uint32_t *rids;
> > > 
> > > 
> > > needs to be initialized with NULL!
> > > 
> > > uint32_t *rids = NULL;
> > > 
> > > or the TALLOC_FREE() in 'done' might crash! Which just happend here!
> > 
> > Hi Andreas,
> > 
> > Fixed version attached (plus I've fixed to match metze's critiques on
> > the coding standards). Sorry for the blunder.
> > 
> > Please re-review - thanks !
> > 
> > Jeremy.
> 
> RB+
> 
> Pushed to autobuild.

Backports to 4.6?

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list