[PATCH] Drop configuration variable CTDB_SERVICE_AUTOSTARTSTOP

Amitay Isaacs amitay at gmail.com
Mon Jan 16 10:00:46 UTC 2017


On Mon, Jan 16, 2017 at 8:10 PM, Martin Schwenke <martin at meltin.net> wrote:

> This drops a bit-rotted feature.  As mentioned in a commit message,
> the feature could be fixed but it is really just unnecessary complexity
> that probably isn't used by anyone.  If anyone is using it then they
> can work around the disappearance of the feature quite trivially.
>
> The main commits are:
>
>   ctdb-scripts: Drop configuration variable CTDB_SERVICE_AUTOSTARTSTOP
>   ctdb-scripts: Remove ctdb_service_start() and ctdb_service_stop()
>
> The rest are just clean-ups that follow on naturally from those 2.  The
> net result is the removal of about 200 lines of code and 50 lines of
> associated tests.  Less is more!  :-)
>
> Please review and maybe push...
>
>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>

A minor fixup to second patch attached.  You can squash it in.
Also noticed that shellcheck test for init_script uses the wrong variable.
Patch attached.  Is there any way to set CTDB_SCRIPTS_INIT_SCRIPT to
$src/config/ctdb.init, so it can work within the source tree?

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patches
Type: application/octet-stream
Size: 2146 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170116/abda0ff0/ctdb.obj>


More information about the samba-technical mailing list