[PATCH] add generated NTSTATUS error module for python

Andrew Bartlett abartlet at samba.org
Fri Jan 13 07:45:18 UTC 2017


On Fri, 2017-01-13 at 12:45 +1300, Bob Campbell wrote:

(a great deal about a lovely patch set)

Bob,

I love the work here.  Just a few nit-picks so far:

- Can you include the source (doc name, source URL and method) for the
error table? eg [MS-ERREF] http://msdn.microsoft.com/en-us/library/cc70
4588.aspx if that is the correct URL (I guess it may not be very
stable).

- in 009-samba-tool-domain-use-generated-ntstatus-rather-than.patch

> +import samba
> +from samba import ntstatus

Do we need the import samba?

I would like someone else to do a good review, as while I can do one
after linux.conf.au next week, someone who wasn't as involved could
probably do a better job.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list