[PATCH] Fix new Coverity IDs

Volker Lendecke vl at samba.org
Wed Jan 11 07:24:26 UTC 2017


On Wed, Jan 11, 2017 at 07:56:04AM +0100, Andreas Schneider wrote:
> > diff --git a/source3/winbindd/winbindd_samr.c
> > b/source3/winbindd/winbindd_samr.c index dd674965f17..d2ce1d2d5e2 100644
> > --- a/source3/winbindd/winbindd_samr.c
> > +++ b/source3/winbindd/winbindd_samr.c
> > @@ -176,8 +176,6 @@ static NTSTATUS sam_query_user_list(struct
> > winbindd_domain *domain,
> > 
> >         DEBUG(3,("samr_query_user_list\n"));
> > 
> > -       *prids = NULL;
> > -
> >         tmp_ctx = talloc_stackframe();
> >         if (tmp_ctx == NULL) {
> >                 return NT_STATUS_NO_MEMORY;
> > 
> > instead ?
> 
> Yes, and we need backports to 4.6 which has already been branched. So could 
> someone please create a bug for them?

This comes from previous code where "num_entries" was unconditionally
initialized always. Now we have rids only as a talloc array carrying
its own length, no "pnum_rids" anymore.

This will then need to go through the (few) callers and make sure we
correctly deal with rids not initialized. During testing I think I
found this is required. Also, we should align winbindd_ads.c.

Volker



More information about the samba-technical mailing list