[PATCHES] remove s4member tests, was Re: ctdb in autobuild broken -- ctdb depends on winbind now????

Rowland Penny repenny241155 at gmail.com
Tue Jan 10 16:01:08 UTC 2017


On Tue, 10 Jan 2017 14:44:50 +0100
Michael Adam <obnox at samba.org> wrote:

> On 2017-01-10 at 12:18 +0000, Rowland Penny wrote:
> > On Tue, 10 Jan 2017 12:22:15 +0100
> > Andreas Schneider <asn at samba.org> wrote:
> > 
> > > On Monday, 9 January 2017 17:03:37 CET Rowland Penny wrote:
> > > > On Mon, 09 Jan 2017 17:52:18 +0100
> > > > 
> > > > Andreas Schneider <asn at samba.org> wrote:
> > > > > 
> > > > > make testenv SELFTEST_TESTENV="s4member:local" SCREEN=1
> > > > 
> > > > Can I ask, is 's4member' the thing you get if you provision with
> > > > '--server-role=member' ???
> > > > If so, why are we testing with something that doesn't actually
> > > > work ???
> > > > 
> > > 
> > > I'm also waiting for a explanation what a s4member actually is ...
> > > 
> > > 
> > 
> > It seems to be a provisioned member server, something the Samba wiki
> > forcefully tells you not to do, see here:
> > https://wiki.samba.org/index.php/Setting_up_Samba_as_a_Domain_Member#Joining_the_Domain
> > 
> > So, I will ask again, why are we testing against something we tell
> > users not to use and is actually broken ???
> 
> Agreed. Let's remove it...
> 
> Cheers - Michael

OK, the attached patches should remove the s4member tests from Samba, so
start objecting now LOL

If I have missed anything, please let me know ;-)

Rowland

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-source3-selftest-tests.py-remove-s4member.patch
Type: text/x-patch
Size: 1524 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0001-source3-selftest-tests.py-remove-s4member.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-source4-selftest-tests.py-remove-s4member.patch
Type: text/x-patch
Size: 7744 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0002-source4-selftest-tests.py-remove-s4member.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-selftest-target-Samba.pm-remove-s4member.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0003-selftest-target-Samba.pm-remove-s4member.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-selftest-target-Samba4.pm-remove-s4member.patch
Type: text/x-patch
Size: 4696 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0004-selftest-target-Samba4.pm-remove-s4member.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-selftest-knownfail-remove-s4member.patch
Type: text/x-patch
Size: 1636 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0005-selftest-knownfail-remove-s4member.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-selftest-README-remove-s4member.patch
Type: text/x-patch
Size: 893 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0006-selftest-README-remove-s4member.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-selftest-skip-remove-s4member.patch
Type: text/x-patch
Size: 775 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170110/32a0a144/0007-selftest-skip-remove-s4member.bin>


More information about the samba-technical mailing list