why is the revert autobuild still running? (was: Re: ctdb in autobuild broken -- ctdb depends on winbind now????)

ronnie sahlberg ronniesahlberg at gmail.com
Fri Jan 6 18:36:30 UTC 2017


To defend VL here. He is doing the right thing.


VL suspects that there is possibility his patch could be causing this.
   +
VL has stated he will not have time to immediately work on
investigation and possible fix.
  =
It is absolutely prudent by VL to rollback to eliminate the chance
that it is his change that is causing the failures.



On Fri, Jan 6, 2017 at 10:23 AM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Fri, 2017-01-06 at 16:00 +0100, Volker Lendecke wrote:
>> On Fri, Jan 06, 2017 at 06:25:41PM +1100, Martin Schwenke wrote:
>> >
>> > On Fri, 6 Jan 2017 07:59:18 +0100, Volker Lendecke <vl at samba.org>
>> > wrote:
>> >
>> > >
>> > > On Fri, Jan 06, 2017 at 05:53:56PM +1100, Martin Schwenke wrote:
>> > > >
>> > > > On Fri, 6 Jan 2017 07:37:52 +0100, Volker Lendecke <vl at samba.or
>> > > > g> wrote:
>> > > >
>> > > > >
>> > > > > On Fri, Jan 06, 2017 at 05:23:30PM +1100, Martin Schwenke
>> > > > > wrote:
>> > >  [...]
>> > > >
>> > > > >
>> > > > >
>> > > > > Why not? The last three weeks were an isolated event where
>> > > > > nobody
>> > > > > called me on the phone for stuff, they were just quiet. I
>> > > > > won't have
>> > > > > time to do serious work for weeks or months, so the only
>> > > > > chance to
>> > > > > unblock the team is a quick revert.
>> > > >
>> > > > Don't we need to understand if this is real failures or flaky
>> > > > tests?
>> > >
>> > > Sure, but as I said: This is a winbind failure, and I don't have
>> > > the
>> > > chance to take a serious look today. Leaving it broken is also no
>> > > option. So please push the reverts just posted.
>> >
>> > As discussed on IRC...
>> >
>> > Can you please merge in my autobuild branch with the reverts and
>> > run a
>> > (or several) private autobuild?  If it passes reliably then:
>> >
>> > Reviewed-by: Martin Schwenke <martin at meltin.net>
>>
>> Survived two autobuilds in a row cleanly. Pushed.
>>
>> I spent the day trying to find a way to tackle this but failed. If
>> possible, we might find some time at SambaXP to work on the patches
>> together.
>
> Volker,
>
> A number of developers (including myself) asked that you not push the
> reverts.
>
> I hope I was clear, but if not I would again ask that you stop the
> autobuild, and let those who asked for time spend the time they
> offered.
>
> Your repeated pattern of rushed reverts is not helpful to the Samba
> project.
>
> Sorry,
>
> Andrew Bartlett
> --
> Andrew Bartlett                       http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
>
>



More information about the samba-technical mailing list