[PATCH] CTDB fixes in sock_daemon and socket I/O code

Martin Schwenke martin at meltin.net
Wed Jan 4 22:45:28 UTC 2017


On Thu, 5 Jan 2017 00:54:30 +1100, Amitay Isaacs <amitay at gmail.com>
wrote:

> Here are the fixes to sock_daemon and sock_io abstractions with tests.
> 
> This should fix the flakey ctdb autobuild.
> 
> Please review and push.

The 4th commit breaks the -O3 developer build:

[194/292] Compiling tests/src/sock_io_test.c
../tests/src/sock_io_test.c: In function ‘test1_writer’:
../tests/src/sock_io_test.c:64:3: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
   *(uint32_t *)buf = buflen;
   ^
../tests/src/sock_io_test.c: In function ‘test2_writer’:
../tests/src/sock_io_test.c:195:3: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
   *(uint32_t *)buf = buflen;
   ^
cc1: all warnings being treated as errors

:-(

I am able to hack around this with the attached patch, which you could
squash in.  However, I suspect there might be a cleaner way...

Still reviewing everything else...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-tests-Fix-O3-developer-build.patch
Type: text/x-patch
Size: 1320 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170105/593439f1/0001-ctdb-tests-Fix-O3-developer-build.bin>


More information about the samba-technical mailing list