[PATCH] Remove some unused code from winbind

Uri Simchoni uri at samba.org
Wed Jan 4 11:13:04 UTC 2017


On 01/04/2017 01:00 PM, Volker Lendecke wrote:
> On Wed, Jan 04, 2017 at 12:42:35PM +0200, Uri Simchoni wrote:
>> On 01/04/2017 12:40 PM, Andreas Schneider wrote:
>>> On Wednesday, 4 January 2017 12:36:01 CET Uri Simchoni wrote:
>>>> On 01/04/2017 12:29 PM, Andreas Schneider wrote:
>>>>> On Wednesday, 4 January 2017 11:44:42 CET Uri Simchoni wrote:
>>>>>> On 01/04/2017 08:18 AM, Volker Lendecke wrote:
>>>>>>> Hi!
>>>>>>>
>>>>>>> Now that getpwsid is changed, we can remove some unused code.
>>>>>>>
>>>>>>> Review appreciated!
>>>>>>>
>>>>>>> Thanks, Volker
>>>>>>
>>>>>> Wow!
>>>>>>
>>>>>> That's what I call radical trimming!
>>>>>>
>>>>>> RB+ me.
>>>>>>
>>>>>> Andreas, since you showed interest in this, do you want to review this
>>>>>> too? There's some non-trivial stuff there, it's not only code removal.
>>>>>
>>>>> Looks fine for me :)
>>>>
>>>> Is that an RB? Just making sure... :)
>>>
>>> RB+
>>>
>> Pushed. (more like "pushing" due to the failures...)
>> Thanks,
> 
> Hmm. Just found that a few commits don't have the Signed-Off-By flag.
> Too many commits these days :-)
> 
> Shall we restart the autobuild with them added?
> 
> Volker
> 
Stopped my submission, will push later if none does.



More information about the samba-technical mailing list