[PATCHES] Fix configure time detection of some features

[Andreas Schneider]

On Tuesday, 27 December 2016 16:41:21 CET Lukas Slebodnik wrote:
> ehlo,

Aloha (slotted),
 
> There was an attempt to have enabled stricter CFLAGS by default
> in fedora rawhide. They changed few warnings to errors:
>   -Werror=implicit-function-declaration -Werror=implicit-int
> 
> Attached patches fix detections for samba related/bundled libraries
> (talloc, tevent, tdb, ldb). It does not fix all detections for samba itself
> becuase I am not sure whether you will like such solution.
> 
> The other possible solution is to ignore CFLAGS for detections
> of features. Something like following code in autotools
>     SAFE_LIBS="$LIBS"
>     LIBS="$DBUS_LIBS"
>     SAFE_CFLAGS=$CFLAGS
>     CFLAGS="$DBUS_CFLAGS"
> 
>     AC_CHECK_FUNC([dbus_watch_get_unix_fd],
>                   AC_DEFINE([HAVE_DBUS_WATCH_GET_UNIX_FD], [1],
>                             [Define if dbus_watch_get_unix_fd exists]))
>     AC_CHECK_TYPES([DBusBasicValue],
>                    [],
>                    [],
>                    [ #include <dbus/dbus.h> ])
> 
>     LIBS="$SAFE_LIBS"
>     CFLAGS=$SAFE_CFLAGS
> 
> But I am not sure how to implement it with waf.


Thanks for your contributions!


I think it is better to fix the issues. Who knows what sideeffects the cause 
if not ...


RB+


Can I get a second reviewer?


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org