[PATCH] Updated script to summarise tshark output

Andrew Bartlett abartlet at samba.org
Tue Feb 28 09:14:31 UTC 2017

On Tue, 2017-02-28 at 11:48 +1300, Gary Lockyer wrote:
> Now displays a help message if started with no options.
> Improved error handling for non pdml input files.
> Improved error handling if XML::Twig is not installed

As well as the included testing, I've already got feedback and a sample
from some users.

It would be great to get this in to Samba.  Can I get a review from a
perl developer on the team for this work please?  I'm quite comfortable
with it, but those who work with perl more than I may have a view.

(I realise we don't normally add much new Perl to Samba, but it seemed
the right language for this kind of text parsing, and allowed Gary to
jump right in to preparing the script)


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list