[PATCH] vfs_fruit checks wrong AAPL config state and so always uses readdirattr

[Uri Simchoni]

On 02/28/2017 08:08 AM, Uri Simchoni wrote:
> On 01/26/2017 01:40 PM, Ralph Böhme wrote:
>> Hi!
>>
>> Attached is a simple fix for this bug:
>> <https://bugzilla.samba.org/show_bug.cgi?id=12541>
>>
>> Kudos to Shilpa Krishnareddy who spotted this!
>>
>> Please review & push if happy. Thanks!
>>
>> Cheerio!
>> -slow
>>
> Question (chiming in VERY late...):
> Since Macs only enable AAPL once per SMB connection (or session, not
> sure which one..), won't this break AAPL when a new tree-connect is
> made? (+ the copyfile and POSIX rename stuff)
> 
> Thanks,
> Uri
> 
I mean, of course, that an additional fix may be required, to persist
neg_aapl across <whatever it should be persistent against>, not that
*this* fix is bad.