[PATCH 08/18] gpo: create a local cifs connection to avoid case issues when searching for policies

Garming Sam garming at catalyst.net.nz
Tue Feb 28 03:44:28 UTC 2017

On 24/02/17 09:49, Andrew Bartlett wrote:
> Thank you so much for taking this on!
> Can you clean up this patch a little?  I know it is as Garming wrote
> it, but it has code that is commented out from the CIFS transition:
Yes, this would be good.

The new code is definitely better and probably handles enough of the
path correctness issues I was concerned about. There seems to be a
missing patch 09/18 that I can't seem to find.

The real lack still is testing. Back when I looked at it originally, I
never quite understood the purpose of the informant python scripts. If
they're supposed to be testing the behaviour, they need to be integrated
(or rewritten) into the overall test system (so we know what works and
what doesn't, or if we break things). Likewise, testlibgpo.py is
basically empty and it would be good to have the python gpo bindings at
least exercised through a test.

Just the other thing is, how often does the periodic script run? Because
it should likely be much less frequent.



More information about the samba-technical mailing list