[PATCH] Python3 compatible modules - credentials, param, _glue

Andrew Bartlett abartlet at samba.org
Sun Feb 26 09:21:32 UTC 2017

On Sun, 2017-02-26 at 16:31 +1300, Andrew Bartlett wrote:
> On Thu, 2017-02-23 at 20:38 +0100, Lumir Balhar wrote:
> > So, from my point of view, it would be better to finalize Stefan's
> > patch 
> > and merge it to master, and then I can rework my patchset (the
> > last 
> > time, hopefully) to be compatible with the latest pytalloc API.
> > 
> > What do you think about it?
> I've done that, it looked like I just need to reject the changes to
> the
> files with conflicts (those attempting a change to PyCapsule).  I
> hope
> I've based it on your most recent work.  I'm running tests on that
> now.
> git://git.samba.org/abartlet/samba.git py3
> https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/he
> ad
> s/py3
> I hope this means we are near the end of this road, and I thank you
> all
> for your contributions and patience!
> Let me know what you think, and I'll let you know what the builds
> come
> up with, then I think we can get a review on this.

Our autobuild runs with strict compile options making warnings errors.

All the python3 builds fail on:

../source4/libnet/py_net.c:722:2: error: missing braces around
initializer [-Werror=missing-braces]
  PyObject_HEAD_INIT(NULL) 0,
../source4/libnet/py_net.c:722:2: error: (near initialization for
py_net_Type.ob_base.ob_base) [-Werror=missing-braces]

The issue is that in python3 the first elements of PyTypeObject changes
from inline to a sub-structure.  

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list