[PATCH] CTDB takeover clean-ups, fixes, optimisations

[Martin Schwenke]

On Fri, 24 Feb 2017 12:44:15 +1100, Martin Schwenke <martin at meltin.net>
wrote:

> On Fri, 24 Feb 2017 12:25:17 +1100, Amitay Isaacs <amitay at gmail.com>
> wrote:
> 
> > On Thu, Feb 23, 2017 at 4:34 PM, Martin Schwenke <martin at meltin.net> wrote:
> >   
> > > Attached are some improvements to the CTDB takeover code.
> > >
> > > This also moves lib/util/bitmap.c to samba-util-core so it is available
> > > to CTDB.
> > >
> > > Please review and maybe push...
> > >
> > >    
> > * ctdb-takeover: Generalise error handling for GET_PUBLIC_IPS
> > 
> > Following hunk is not required.  You don't need to test the framework.
> > 
> > +        if (! found_errors) {
> > +            D_ERR("control GET_PUBLIC_IPS internal error, "
> >                    "ret=%d\n", ret);
> > +            err_any = EIO;
> >          }  
> 
> OK  :-)
> 
> > * ctdb-takeover: Fetch public IP addresses from all connected nodes
> > 
> > Change the commit message to "Fetch known public IP ...".
> > 
> > The side-effect of this patch is that an already banned node can get banned
> > again now that you have added banning on get_public_ips failure.  I guess
> > it will get re-banned even if it fails to reply to redundant releases.  
> 
> Yeah, there's nothing else we can do.  Similar to the case where a node
> continually fails to release.  We keep retrying and banning.

Pushed your branch containing all the stuff I posted plus your
fixups to autobuild (with the final fixup squashed in).

peace & happiness,
martin