[PATCH] CTDB NFS Ganesha example call-out improvements

Martin Schwenke martin at meltin.net
Fri Feb 24 01:45:18 UTC 2017


On Fri, 24 Feb 2017 12:31:06 +1100, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Fri, Feb 24, 2017 at 11:56 AM, Martin Schwenke <martin at meltin.net> wrote:
> 
> > On Fri, 24 Feb 2017 11:48:29 +1100, Amitay Isaacs <amitay at gmail.com>
> > wrote:
> >  
> > > On Thu, Feb 23, 2017 at 4:37 PM, Martin Schwenke <martin at meltin.net>  
> > wrote:  
> > >  
>  [...]  
> > > In the patch "ctdb-doc: Fix shellcheck warning in example NFS ganesha
> > > call-out"
> > >
> > >             [ -d "$_dir" ] || continue # Handle no directories case
> > >
> > > Wouldn't the following make it clearer?
> > >
> > >             [ ! -d "$_dir" ] && break   # Handle no directories case  
> >
> > Yeah, let's go with that.
> >
> > I was actually thinking of using an if-statement for clarity but decided
> > to keep it brief...  either way...  :-)
> >
> >  
> Yeah, using if-statement is even better.  Will change to that.

Yeah, I used to love keeping the code short.  Now I just like the code
to tell me what it is doing without having to interpret weird
abbreviations...  :-)

peace & happiness,
martin



More information about the samba-technical mailing list