[PATCH] CTDB NFS Ganesha example call-out improvements
amitay at gmail.com
Fri Feb 24 01:31:06 UTC 2017
On Fri, Feb 24, 2017 at 11:56 AM, Martin Schwenke <martin at meltin.net> wrote:
> On Fri, 24 Feb 2017 11:48:29 +1100, Amitay Isaacs <amitay at gmail.com>
> > On Thu, Feb 23, 2017 at 4:37 PM, Martin Schwenke <martin at meltin.net>
> > > I was adding some wiki documentation about how CTDB's NFS call-outs
> > > work. I referenced nfs-ganesha-callout, so I decided to fix it up a
> > > little, even though it is still just an example in the documentation
> > > directory.
> > >
> > > Please review and maybe push...
> > >
> > >
> > In the patch "ctdb-doc: Fix shellcheck warning in example NFS ganesha
> > call-out"
> > [ -d "$_dir" ] || continue # Handle no directories case
> > Wouldn't the following make it clearer?
> > [ ! -d "$_dir" ] && break # Handle no directories case
> Yeah, let's go with that.
> I was actually thinking of using an if-statement for clarity but decided
> to keep it brief... either way... :-)
Yeah, using if-statement is even better. Will change to that.
More information about the samba-technical